[Security Solution] Unskip timeline creation Cypress test #85871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
v8.0.0
release_note:skip
| @@ -103,7 +105,7 @@ export const TIMELINE_FIELDS_BUTTON = | |||
| '[data-test-subj="timeline"] [data-test-subj="show-field-browser"]'; | |||
|
|
|||
| export const TIMELINE_FILTER = (filter: TimelineFilter) => { | |||
| return `[data-test-subj="filter filter-enabled filter-key-${filter.field} filter-value-${filter.value} filter-unpinned"]`; | |||
| return `[data-test-subj="filter filter-enabled filter-key-${filter.field} filter-value-${filter.value} filter-unpinned "]`; | |||
There was a problem hiding this comment.
was this extra space on the end here meaningful in some way?
There was a problem hiding this comment.
As it is how it looks atm, and the component is not made by us. Update it here to fit current case and get the right element.
There was a problem hiding this comment.
Sounds good. Could you add a comment to that effect? Someone's editor may accidentally fix that on save or something and recreate the error. Might be worth contacting the code owners of the component too, to just remove the space in their code as well.
There was a problem hiding this comment.
I agree with @michaelolo24, we should fix the code and see if break anything else
michaelolo24
approved these changes
Dec 14, 2020
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to ymao1/kibana
that referenced
this pull request
Dec 15, 2020
* master: (66 commits) [Alerting] fixes broken Alerting Example plugin (elastic#85774) [APM] Service overview instances table (elastic#85770) [Security Solution] Unskip timeline creation Cypress test (elastic#85871) properly recognize enterprise licenses (elastic#85849) [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690) [TSVB] Fix functional tests flakiness and unskip them (elastic#85388) [Fleet] Change permissions for Fleet enroll role (elastic#85802) Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768) [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488) [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424) skip flaky suite (elastic#78553) License checks for alerts plugin (elastic#85649) skip flaky suite (elastic#84992) skip 'query return results valid for scripted field' elastic#78553 Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919) [ML] More machine learning links in doc_links_service.ts (elastic#85365) Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652) Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859) Fix outdated jest snapshot [Maps] Surface on prem EMS (elastic#85729) ...
| @@ -46,11 +47,11 @@ import { openTimeline } from '../tasks/timelines'; | |||
| import { OVERVIEW_URL } from '../urls/navigation'; | |||
|
|
|||
| // FLAKY: https://github.com/elastic/kibana/issues/79389 | |||
There was a problem hiding this comment.
Can you please remove this line and close the related ticket if is still opened?
| getTimelineById(timelineId).then((singleTimeline) => { | ||
| const noteId = singleTimeline!.body.data.getOneTimeline.notes[0].noteId; | ||
|
|
||
| cy.get(`${NOTE_BY_NOTE_ID(noteId)} p`).should('have.text', timeline.notes); |
There was a problem hiding this comment.
Can we please extract this to our screens folder?
|
Thank you @MadameSheema , I've fixed them in #85905 |
angorayc
added a commit
that referenced
this pull request
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#79389